| 1 | """Unit tests for render._skill_version() fallback paths. |
| 2 | |
| 3 | The function reads version from .claude-plugin/plugin.json first, then falls back |
| 4 | to SKILL.md frontmatter. These tests use monkeypatch to swap the render module's |
| 5 | __file__ attribute, which controls where the walk starts. |
| 6 | """ |
| 7 | |
| 8 | import unittest |
| 9 | from pathlib import Path |
| 10 | from unittest.mock import patch |
| 11 | |
| 12 | from lib import render |
| 13 | |
| 14 | |
| 15 | class SkillVersionFallbackTests(unittest.TestCase): |
| 16 | def setUp(self): |
| 17 | # tmp_path equivalent for unittest |
| 18 | import tempfile |
| 19 | self._tmp = tempfile.TemporaryDirectory() |
| 20 | self.tmp_path = Path(self._tmp.name) |
| 21 | |
| 22 | def tearDown(self): |
| 23 | self._tmp.cleanup() |
| 24 | |
| 25 | def _make_render_at(self, parent: Path) -> Path: |
| 26 | """Place a dummy render.py inside parent and return its path.""" |
| 27 | parent.mkdir(parents=True, exist_ok=True) |
| 28 | fake_render = parent / "render.py" |
| 29 | fake_render.write_text("") |
| 30 | return fake_render |
| 31 | |
| 32 | def _write_manifest(self, parent: Path, version: str | None) -> None: |
| 33 | """Write .claude-plugin/plugin.json under parent. version=None writes corrupt JSON.""" |
| 34 | d = parent / ".claude-plugin" |
| 35 | d.mkdir(parents=True, exist_ok=True) |
| 36 | if version is None: |
| 37 | (d / "plugin.json").write_text("{not valid json") |
| 38 | else: |
| 39 | (d / "plugin.json").write_text(f'{{"version": "{version}"}}') |
| 40 | |
| 41 | def _write_skill_md(self, parent: Path, frontmatter_version_line: str | None) -> None: |
| 42 | """Write SKILL.md with frontmatter. None writes a SKILL.md with no version line.""" |
| 43 | if frontmatter_version_line is None: |
| 44 | body = "---\nname: test\n---\n# body\n" |
| 45 | else: |
| 46 | body = f"---\nname: test\n{frontmatter_version_line}\n---\n# body\n" |
| 47 | (parent / "SKILL.md").write_text(body) |
| 48 | |
| 49 | def test_manifest_absent_falls_back_to_skill_md_frontmatter(self): |
| 50 | skill_dir = self.tmp_path / "skill_root" |
| 51 | fake_render = self._make_render_at(skill_dir) |
| 52 | self._write_skill_md(skill_dir, 'version: "9.9.9"') |
| 53 | |
| 54 | with patch.object(render, "__file__", str(fake_render)): |
| 55 | self.assertEqual("9.9.9", render._skill_version()) |
| 56 | |
| 57 | def test_manifest_corrupt_falls_back_to_skill_md_frontmatter(self): |
| 58 | skill_dir = self.tmp_path / "skill_root" |
| 59 | fake_render = self._make_render_at(skill_dir) |
| 60 | self._write_manifest(skill_dir, version=None) # corrupt |
| 61 | self._write_skill_md(skill_dir, 'version: "8.8.8"') |
| 62 | |
| 63 | with patch.object(render, "__file__", str(fake_render)): |
| 64 | self.assertEqual("8.8.8", render._skill_version()) |
| 65 | |
| 66 | def test_manifest_missing_version_key_falls_back_to_skill_md_frontmatter(self): |
| 67 | # Valid JSON, but no "version" key. Old behavior returned "?" and never tried |
| 68 | # SKILL.md. Fix from greptile review: fall through to SKILL.md fallback. |
| 69 | skill_dir = self.tmp_path / "skill_root" |
| 70 | fake_render = self._make_render_at(skill_dir) |
| 71 | (skill_dir / ".claude-plugin").mkdir() |
| 72 | (skill_dir / ".claude-plugin" / "plugin.json").write_text('{"name": "x"}') |
| 73 | self._write_skill_md(skill_dir, 'version: "4.4.4"') |
| 74 | |
| 75 | with patch.object(render, "__file__", str(fake_render)): |
| 76 | self.assertEqual("4.4.4", render._skill_version()) |
| 77 | |
| 78 | def test_manifest_empty_version_string_falls_back_to_skill_md_frontmatter(self): |
| 79 | # Manifest version present but empty — treat as missing so the badge |
| 80 | # doesn't emit a useless "🌐 last30days v · synced ..." line. |
| 81 | skill_dir = self.tmp_path / "skill_root" |
| 82 | fake_render = self._make_render_at(skill_dir) |
| 83 | (skill_dir / ".claude-plugin").mkdir() |
| 84 | (skill_dir / ".claude-plugin" / "plugin.json").write_text('{"version": ""}') |
| 85 | self._write_skill_md(skill_dir, 'version: "2.2.2"') |
| 86 | |
| 87 | with patch.object(render, "__file__", str(fake_render)): |
| 88 | self.assertEqual("2.2.2", render._skill_version()) |
| 89 | |
| 90 | def test_corrupt_inner_manifest_does_not_shadow_valid_outer_manifest(self): |
| 91 | outer = self.tmp_path / "outer" |
| 92 | inner = outer / "skill_root" |
| 93 | fake_render = self._make_render_at(inner) |
| 94 | self._write_manifest(inner, version=None) # corrupt at inner |
| 95 | self._write_manifest(outer, version="7.7.7") # valid at outer |
| 96 | |
| 97 | with patch.object(render, "__file__", str(fake_render)): |
| 98 | self.assertEqual("7.7.7", render._skill_version()) |
| 99 | |
| 100 | def test_neither_source_present_returns_question_mark(self): |
| 101 | skill_dir = self.tmp_path / "skill_root" |
| 102 | fake_render = self._make_render_at(skill_dir) |
| 103 | # No manifest, no SKILL.md anywhere under tmp_path |
| 104 | |
| 105 | with patch.object(render, "__file__", str(fake_render)): |
| 106 | self.assertEqual("?", render._skill_version()) |
| 107 | |
| 108 | def test_skill_md_without_version_returns_question_mark(self): |
| 109 | skill_dir = self.tmp_path / "skill_root" |
| 110 | fake_render = self._make_render_at(skill_dir) |
| 111 | self._write_skill_md(skill_dir, frontmatter_version_line=None) |
| 112 | |
| 113 | with patch.object(render, "__file__", str(fake_render)): |
| 114 | self.assertEqual("?", render._skill_version()) |
| 115 | |
| 116 | def test_unquoted_yaml_version_is_accepted(self): |
| 117 | skill_dir = self.tmp_path / "skill_root" |
| 118 | fake_render = self._make_render_at(skill_dir) |
| 119 | self._write_skill_md(skill_dir, "version: 6.6.6") |
| 120 | |
| 121 | with patch.object(render, "__file__", str(fake_render)): |
| 122 | self.assertEqual("6.6.6", render._skill_version()) |
| 123 | |
| 124 | def test_single_quoted_yaml_version_is_accepted(self): |
| 125 | skill_dir = self.tmp_path / "skill_root" |
| 126 | fake_render = self._make_render_at(skill_dir) |
| 127 | self._write_skill_md(skill_dir, "version: '5.5.5'") |
| 128 | |
| 129 | with patch.object(render, "__file__", str(fake_render)): |
| 130 | self.assertEqual("5.5.5", render._skill_version()) |
| 131 | |
| 132 | if __name__ == "__main__": |
| 133 | unittest.main() |
| 134 |