| 1 | package config |
| 2 | |
| 3 | import ( |
| 4 | "os" |
| 5 | "path/filepath" |
| 6 | "reflect" |
| 7 | "runtime" |
| 8 | "strconv" |
| 9 | "strings" |
| 10 | "testing" |
| 11 | |
| 12 | "github.com/BurntSushi/toml" |
| 13 | ) |
| 14 | |
| 15 | func isolateUserConfigHome(t *testing.T) string { |
| 16 | t.Helper() |
| 17 | home := t.TempDir() |
| 18 | t.Setenv("HOME", home) |
| 19 | for _, key := range []string{"REASONIX_HOME", "REASONIX_STATE_HOME", "REASONIX_CACHE_HOME"} { |
| 20 | t.Setenv(key, "") |
| 21 | if err := os.Unsetenv(key); err != nil { |
| 22 | t.Fatalf("unset %s: %v", key, err) |
| 23 | } |
| 24 | } |
| 25 | t.Setenv("REASONIX_CREDENTIALS_STORE", "file") |
| 26 | t.Setenv("USERPROFILE", home) |
| 27 | t.Setenv("XDG_CONFIG_HOME", filepath.Join(home, ".config")) |
| 28 | t.Setenv("AppData", filepath.Join(home, "AppData", "Roaming")) |
| 29 | return home |
| 30 | } |
| 31 | |
| 32 | // setRuntimeGOOS overrides the package-level runtimeGOOS for one test. The |
| 33 | // t.Setenv call is a guard: it panics if the test also uses t.Parallel, which |
| 34 | // would otherwise race on the shared global. |
| 35 | func setRuntimeGOOS(t *testing.T, goos string) { |
| 36 | t.Helper() |
| 37 | t.Setenv("REASONIX_TEST_GOOS", goos) |
| 38 | old := runtimeGOOS |
| 39 | runtimeGOOS = goos |
| 40 | t.Cleanup(func() { runtimeGOOS = old }) |
| 41 | } |
| 42 | |
| 43 | func expectedDefaultReasonixHome(home string) string { |
| 44 | if runtime.GOOS == "windows" { |
| 45 | return filepath.Join(home, "AppData", "Roaming", "reasonix") |
| 46 | } |
| 47 | return filepath.Join(home, ".reasonix") |
| 48 | } |
| 49 | |
| 50 | func TestUserConfigDisplayPathCollapsesHome(t *testing.T) { |
| 51 | home := isolateUserConfigHome(t) |
| 52 | got := userConfigDisplayPath() |
| 53 | if !strings.HasPrefix(got, "~/") { |
| 54 | t.Fatalf("display path = %q, want ~/ prefix", got) |
| 55 | } |
| 56 | if !strings.HasSuffix(got, "reasonix/config.toml") { |
| 57 | t.Fatalf("display path = %q, want reasonix/config.toml suffix", got) |
| 58 | } |
| 59 | if strings.Contains(got, home) { |
| 60 | t.Fatalf("display path %q must not embed the absolute home", got) |
| 61 | } |
| 62 | } |
| 63 | |
| 64 | func TestUserConfigPathUsesReasonixHome(t *testing.T) { |
| 65 | home := isolateUserConfigHome(t) |
| 66 | want := filepath.Join(expectedDefaultReasonixHome(home), "config.toml") |
| 67 | if got := UserConfigPath(); filepath.Clean(got) != filepath.Clean(want) { |
| 68 | t.Fatalf("UserConfigPath() = %q, want %q", got, want) |
| 69 | } |
| 70 | } |
| 71 | |
| 72 | func TestReasonixManagedConfigPathsAreConfigFilesOnly(t *testing.T) { |
| 73 | home := isolateUserConfigHome(t) |
| 74 | setRuntimeGOOS(t, "windows") |
| 75 | oldConfigDir := osUserConfigDir |
| 76 | osUserConfigDir = func() string { return filepath.Join(home, "AppData", "Roaming") } |
| 77 | t.Cleanup(func() { osUserConfigDir = oldConfigDir }) |
| 78 | |
| 79 | paths := ReasonixManagedConfigPaths() |
| 80 | for _, want := range []string{ |
| 81 | filepath.Join(home, "AppData", "Roaming", "reasonix", "config.toml"), |
| 82 | filepath.Join(home, ".reasonix", "config.json"), |
| 83 | } { |
| 84 | found := false |
| 85 | for _, got := range paths { |
| 86 | if samePath(got, want) { |
| 87 | found = true |
| 88 | break |
| 89 | } |
| 90 | } |
| 91 | if !found { |
| 92 | t.Fatalf("managed config paths = %v, want %s", paths, want) |
| 93 | } |
| 94 | } |
| 95 | // The escape hatch is file-level by contract: no directories, and none of |
| 96 | // the sensitive Reasonix-home siblings (credentials, hooks, skills, |
| 97 | // sessions) may ride along. |
| 98 | for _, got := range paths { |
| 99 | if base := filepath.Base(got); base != "config.toml" && base != "config.json" { |
| 100 | t.Fatalf("managed config path %q is not a known config file (paths must be files, not directories): %v", got, paths) |
| 101 | } |
| 102 | for _, forbidden := range []string{ |
| 103 | home, |
| 104 | ReasonixHomeDir(), |
| 105 | UserCredentialsPath(), |
| 106 | filepath.Join(ReasonixHomeDir(), "settings.json"), |
| 107 | filepath.Join(ReasonixHomeDir(), "skills"), |
| 108 | filepath.Join(ReasonixHomeDir(), "sessions"), |
| 109 | } { |
| 110 | if samePath(got, forbidden) { |
| 111 | t.Fatalf("managed config paths must not include %q: %v", forbidden, paths) |
| 112 | } |
| 113 | } |
| 114 | } |
| 115 | } |
| 116 | |
| 117 | func TestUserConfigPathHonorsReasonixHome(t *testing.T) { |
| 118 | home := isolateUserConfigHome(t) |
| 119 | custom := filepath.Join(home, "custom-home") |
| 120 | t.Setenv("REASONIX_HOME", custom) |
| 121 | |
| 122 | want := filepath.Join(custom, "config.toml") |
| 123 | if got := UserConfigPath(); filepath.Clean(got) != filepath.Clean(want) { |
| 124 | t.Fatalf("UserConfigPath() = %q, want %q", got, want) |
| 125 | } |
| 126 | } |
| 127 | |
| 128 | func TestLoadForRootUsesWindowsHomeFallbackWhenConfigDirUnavailable(t *testing.T) { |
| 129 | home := t.TempDir() |
| 130 | project := t.TempDir() |
| 131 | |
| 132 | oldGOOS := runtimeGOOS |
| 133 | oldConfigDir := osUserConfigDir |
| 134 | oldHomeDir := osUserHomeDir |
| 135 | runtimeGOOS = "windows" |
| 136 | osUserConfigDir = func() string { return "" } |
| 137 | osUserHomeDir = func() (string, error) { return home, nil } |
| 138 | t.Cleanup(func() { |
| 139 | runtimeGOOS = oldGOOS |
| 140 | osUserConfigDir = oldConfigDir |
| 141 | osUserHomeDir = oldHomeDir |
| 142 | }) |
| 143 | |
| 144 | t.Setenv("REASONIX_HOME", "") |
| 145 | |
| 146 | configPath := filepath.Join(home, "AppData", "Roaming", "reasonix", "config.toml") |
| 147 | if err := os.MkdirAll(filepath.Dir(configPath), 0o755); err != nil { |
| 148 | t.Fatal(err) |
| 149 | } |
| 150 | if err := os.WriteFile(configPath, []byte("default_model = \"custom/from-home\"\n"), 0o600); err != nil { |
| 151 | t.Fatal(err) |
| 152 | } |
| 153 | |
| 154 | cfg, err := LoadForRoot(project) |
| 155 | if err != nil { |
| 156 | t.Fatalf("LoadForRoot() error = %v", err) |
| 157 | } |
| 158 | if cfg.DefaultModel != "custom/from-home" { |
| 159 | t.Fatalf("DefaultModel = %q, want %q", cfg.DefaultModel, "custom/from-home") |
| 160 | } |
| 161 | } |
| 162 | |
| 163 | func TestRenderTOMLHeaderShowsResolvedConfigPath(t *testing.T) { |
| 164 | isolateUserConfigHome(t) |
| 165 | out := RenderTOML(Default()) |
| 166 | want := "> " + userConfigDisplayPath() + " > built-in defaults." |
| 167 | if !strings.Contains(out, want) { |
| 168 | t.Fatalf("rendered header missing resolved config path %q", want) |
| 169 | } |
| 170 | } |
| 171 | |
| 172 | func TestWriteRootsForRootExcludesUserConfigDirByDefault(t *testing.T) { |
| 173 | isolateUserConfigHome(t) |
| 174 | project := t.TempDir() |
| 175 | cfg := Default() |
| 176 | |
| 177 | roots := cfg.WriteRootsForRoot(project) |
| 178 | want := filepath.Clean(filepath.Dir(UserConfigPath())) |
| 179 | for _, root := range roots { |
| 180 | if filepath.Clean(root) == want { |
| 181 | t.Fatalf("WriteRootsForRoot() = %v, must not include user config dir %q by default", roots, want) |
| 182 | } |
| 183 | } |
| 184 | if got := filepath.Clean(roots[0]); got != filepath.Clean(project) { |
| 185 | t.Fatalf("first write root = %q, want project %q", got, project) |
| 186 | } |
| 187 | } |
| 188 | |
| 189 | // TestRenderTOMLRoundTrips ensures the annotated TOML we emit parses back into |
| 190 | // an equivalent config — i.e. the wizard never writes a file it can't read. |
| 191 | func TestRenderTOMLRoundTrips(t *testing.T) { |
| 192 | orig := Default() |
| 193 | orig.Providers = append(orig.Providers, legacyMimoCustomProvider("mimo-pro")) |
| 194 | orig.DefaultModel = "mimo-pro" |
| 195 | orig.Language = "zh" |
| 196 | orig.UI.Theme = "light" |
| 197 | orig.UI.ThemeStyle = "glacier" |
| 198 | orig.UI.ShortcutLayout = "desktop" |
| 199 | orig.UI.CursorShape = "bar" |
| 200 | orig.Desktop.Language = "en" |
| 201 | orig.Desktop.LayoutStyle = "workbench" |
| 202 | orig.Desktop.Theme = "dark" |
| 203 | orig.Desktop.ThemeStyle = "graphite" |
| 204 | orig.Desktop.TerminalTheme = "light" |
| 205 | orig.Desktop.CloseBehavior = "background" |
| 206 | orig.Desktop.DisplayMode = "compact" |
| 207 | orig.Desktop.StatusBarStyle = "text" |
| 208 | orig.Desktop.StatusBarStyleInitialized = true |
| 209 | orig.Desktop.StatusBarItems = []string{"model", "balance", "cache"} |
| 210 | orig.Desktop.DefaultToolApprovalMode = "auto" |
| 211 | orig.Desktop.CheckUpdates = boolPtr(false) |
| 212 | orig.Desktop.UpdateChannel = "preview" |
| 213 | orig.Desktop.Telemetry = boolPtr(false) |
| 214 | orig.Notifications.Enabled = true |
| 215 | orig.Notifications.TurnDone = true |
| 216 | orig.Notifications.ApprovalRequest = true |
| 217 | orig.Notifications.AskRequest = true |
| 218 | orig.Agent.RecoveryModel = "mimo-pro" |
| 219 | orig.Agent.RecoveryTemperature = 0.15 |
| 220 | orig.Agent.ReasoningLanguage = "zh" |
| 221 | orig.Agent.CompactRatio = 0.8 |
| 222 | orig.Agent.SubagentModel = "mimo-pro" |
| 223 | orig.Agent.SubagentModels = map[string]string{"review": "deepseek-pro"} |
| 224 | orig.Agent.MaxSubagentDepth = 3 |
| 225 | orig.Agent.Keep = []string{"errors", "user_marked"} |
| 226 | orig.Agent.RecentKeep = 4 |
| 227 | orig.Tools.BashTimeoutSeconds = intPtr(900) |
| 228 | orig.Tools.BackgroundJobs.StalledWarningSeconds = intPtr(30) |
| 229 | orig.Tools.Shell.Prefer = "bash" |
| 230 | orig.Tools.Shell.Path = "/usr/local/bin/bash" |
| 231 | orig.Permissions = PermissionsConfig{ |
| 232 | Mode: "deny", |
| 233 | Deny: []string{"Bash(rm -rf*)"}, |
| 234 | Allow: []string{"Bash(go test:*)", "read_file"}, |
| 235 | AllowDynamicBash: true, |
| 236 | } |
| 237 | orig.Network = NetworkConfig{ |
| 238 | ProxyMode: "custom", |
| 239 | NoProxy: "localhost,127.0.0.1", |
| 240 | Proxy: NetworkProxyConfig{ |
| 241 | Type: "socks5", |
| 242 | Server: "127.0.0.1", |
| 243 | Port: 7890, |
| 244 | Username: "user", |
| 245 | Password: "${REASONIX_PROXY_PASSWORD}", |
| 246 | }, |
| 247 | } |
| 248 | orig.Environment.Enabled = boolPtr(false) |
| 249 | orig.Environment.Tools = map[string]string{"go": "/opt/homebrew/bin/go", "python3": "~/.pyenv/shims/python3"} |
| 250 | orig.Skills.Paths = []string{"~/my-skills", "../shared/skills"} |
| 251 | orig.Skills.ExcludedPaths = []string{"~/.agents/skills"} |
| 252 | orig.Skills.DisabledSkills = []string{"review", "explore"} |
| 253 | orig.Skills.DisableImplicitInvocation = true |
| 254 | orig.Skills.MaxDepth = 2 |
| 255 | orig.Bot.ToolApprovalMode = "auto" |
| 256 | orig.Bot.Control = BotControlConfig{Enabled: true, Addr: "127.0.0.1:39001", TokenEnv: "BOT_CONTROL_TOKEN"} |
| 257 | orig.Bot.Feishu.OutboundMediaRoots = []string{"/tmp/reasonix-media", "/srv/shots"} |
| 258 | orig.Bot.Routes = []BotRouteConfig{{ |
| 259 | ConnectionID: "feishu-lark", |
| 260 | ChatType: "group", |
| 261 | ChatID: "oc_group", |
| 262 | Model: "deepseek-pro", |
| 263 | ToolApprovalMode: "ask", |
| 264 | WorkspaceRoot: "/tmp/reasonix-route", |
| 265 | }} |
| 266 | orig.Bot.DesktopWatchers = []BotDesktopWatcherConfig{{ |
| 267 | Platform: "feishu", |
| 268 | ConnectionID: "feishu-lark", |
| 269 | Domain: "lark", |
| 270 | ChatType: "dm", |
| 271 | ChatID: "oc_watcher", |
| 272 | }} |
| 273 | orig.Bot.Connections = []BotConnectionConfig{{ |
| 274 | ID: "feishu-lark", |
| 275 | Provider: "feishu", |
| 276 | Domain: "lark", |
| 277 | Label: "Lark", |
| 278 | Enabled: true, |
| 279 | Status: "connected", |
| 280 | Model: "deepseek-pro", |
| 281 | ToolApprovalMode: "yolo", |
| 282 | WorkspaceRoot: "/tmp/reasonix-bot", |
| 283 | Credential: BotConnectionCredential{AppID: "cli_lark", AppSecretEnv: "LARK_BOT_APP_SECRET"}, |
| 284 | SessionMappings: []BotConnectionSessionMapping{{ |
| 285 | RemoteID: "ou_123", |
| 286 | SessionID: "topic:topic_bot", |
| 287 | Scope: "project", |
| 288 | WorkspaceRoot: "/tmp/reasonix-bot", |
| 289 | UpdatedAt: "2026-06-11T00:00:00Z", |
| 290 | }}, |
| 291 | }} |
| 292 | orig.LSP = LSPConfig{ |
| 293 | Enabled: true, |
| 294 | Servers: map[string]LSPServer{ |
| 295 | "lua": { |
| 296 | Command: "lua-language-server", |
| 297 | Args: []string{"--stdio"}, |
| 298 | Env: map[string]string{"LUA_PATH": "./?.lua"}, |
| 299 | LanguageID: "lua", |
| 300 | Extensions: []string{".lua", ".script", ".gui_script"}, |
| 301 | InstallHint: "install lua-language-server", |
| 302 | }, |
| 303 | }, |
| 304 | } |
| 305 | orig.Plugins = []PluginEntry{ |
| 306 | {Name: "example", Command: "reasonix-plugin-example"}, |
| 307 | {Name: "stripe", Type: "http", URL: "https://mcp.stripe.com", Headers: map[string]string{"Authorization": "Bearer x"}, AutoStart: boolPtr(false), Tier: "background"}, |
| 308 | } |
| 309 | mm, _ := orig.Provider("mimo-pro") |
| 310 | mm.BaseURL = "http://localhost:8000/v1" |
| 311 | mm.ChatURL = "http://localhost:8000/v1/chat/completions" |
| 312 | mm.RequestURL = "http://localhost:8000/custom/chat/completions/?token=1" |
| 313 | mm.ModelsURL = "http://localhost:8000/v1/models" |
| 314 | mm.ReasoningProtocol = "openai" |
| 315 | mm.PresetID = "mimo-api" |
| 316 | mm.PresetVersion = ProviderPresetVersion |
| 317 | ds, _ := orig.Provider("deepseek-flash") |
| 318 | ds.Effort = "max" |
| 319 | |
| 320 | rendered := RenderTOML(orig) |
| 321 | |
| 322 | var got Config |
| 323 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 324 | t.Fatalf("rendered TOML does not parse: %v\n---\n%s", err, rendered) |
| 325 | } |
| 326 | |
| 327 | if got.DefaultModel != "mimo-pro" { |
| 328 | t.Errorf("default_model = %q, want mimo-pro", got.DefaultModel) |
| 329 | } |
| 330 | if got.ConfigVersion != Default().ConfigVersion { |
| 331 | t.Errorf("config_version = %d, want %d", got.ConfigVersion, Default().ConfigVersion) |
| 332 | } |
| 333 | if got.Language != "zh" { |
| 334 | t.Errorf("language = %q, want zh", got.Language) |
| 335 | } |
| 336 | if got.UI.Theme != "light" { |
| 337 | t.Errorf("ui.theme = %q, want light", got.UI.Theme) |
| 338 | } |
| 339 | if got.UI.ThemeStyle != "glacier" { |
| 340 | t.Errorf("ui.theme_style = %q, want glacier", got.UI.ThemeStyle) |
| 341 | } |
| 342 | if got.UI.ShortcutLayout != "desktop" { |
| 343 | t.Errorf("ui.shortcut_layout = %q, want desktop", got.UI.ShortcutLayout) |
| 344 | } |
| 345 | if got.UICursorShape() != "bar" { |
| 346 | t.Errorf("ui.cursor_shape = %q, want bar", got.UICursorShape()) |
| 347 | } |
| 348 | if !got.UI.ShowTurnUsage { |
| 349 | t.Error("ui.show_turn_usage = false, want true") |
| 350 | } |
| 351 | if got.Desktop.Language != "en" { |
| 352 | t.Errorf("desktop.language = %q, want en", got.Desktop.Language) |
| 353 | } |
| 354 | if got.Desktop.LayoutStyle != "workbench" { |
| 355 | t.Errorf("desktop.layout_style = %q, want workbench", got.Desktop.LayoutStyle) |
| 356 | } |
| 357 | if got.Desktop.Theme != "dark" { |
| 358 | t.Errorf("desktop.theme = %q, want dark", got.Desktop.Theme) |
| 359 | } |
| 360 | if got.Desktop.ThemeStyle != "graphite" { |
| 361 | t.Errorf("desktop.theme_style = %q, want graphite", got.Desktop.ThemeStyle) |
| 362 | } |
| 363 | if got.Desktop.TerminalTheme != "light" { |
| 364 | t.Errorf("desktop.terminal_theme = %q, want light", got.Desktop.TerminalTheme) |
| 365 | } |
| 366 | if got.Desktop.CloseBehavior != "background" { |
| 367 | t.Errorf("desktop.close_behavior = %q, want background", got.Desktop.CloseBehavior) |
| 368 | } |
| 369 | if got.DesktopDisplayMode() != "compact" { |
| 370 | t.Errorf("desktop.display_mode = %q, want compact", got.DesktopDisplayMode()) |
| 371 | } |
| 372 | if got.Desktop.StatusBarStyle != "text" { |
| 373 | t.Errorf("desktop.status_bar_style = %q, want text", got.Desktop.StatusBarStyle) |
| 374 | } |
| 375 | if want := []string{"model", "balance", "cache"}; !reflect.DeepEqual(got.Desktop.StatusBarItems, want) { |
| 376 | t.Errorf("desktop.status_bar_items = %v, want %v", got.Desktop.StatusBarItems, want) |
| 377 | } |
| 378 | if got.DesktopDefaultToolApprovalMode() != "workspace-write" { |
| 379 | t.Errorf("desktop.default_tool_approval_mode = %q, want workspace-write", got.DesktopDefaultToolApprovalMode()) |
| 380 | } |
| 381 | if got.Desktop.CheckUpdates == nil || *got.Desktop.CheckUpdates { |
| 382 | t.Errorf("desktop.check_updates = %+v, want false", got.Desktop.CheckUpdates) |
| 383 | } |
| 384 | if got.DesktopUpdateChannel() != "stable" { |
| 385 | t.Errorf("desktop.update_channel = %q, want stable", got.DesktopUpdateChannel()) |
| 386 | } |
| 387 | if got.Agent.RecoveryModel != "" || got.Agent.RecoveryTemperature != 0 { |
| 388 | t.Errorf("retired agent recovery settings rendered: %+v", got.Agent) |
| 389 | } |
| 390 | if !got.Notifications.Enabled || !got.Notifications.TurnDone || !got.Notifications.ApprovalRequest || !got.Notifications.AskRequest { |
| 391 | t.Errorf("notifications not preserved: %+v", got.Notifications) |
| 392 | } |
| 393 | if got.Agent.MaxSteps != orig.Agent.MaxSteps { |
| 394 | t.Errorf("max_steps = %d, want %d", got.Agent.MaxSteps, orig.Agent.MaxSteps) |
| 395 | } |
| 396 | if got.Agent.PlannerMaxSteps != orig.Agent.PlannerMaxSteps { |
| 397 | t.Errorf("planner_max_steps = %d, want %d", got.Agent.PlannerMaxSteps, orig.Agent.PlannerMaxSteps) |
| 398 | } |
| 399 | if len(got.Bot.Connections) != 1 || got.Bot.Connections[0].Model != "deepseek-pro" || got.Bot.Connections[0].WorkspaceRoot != "/tmp/reasonix-bot" { |
| 400 | t.Errorf("bot connection not preserved: %+v", got.Bot.Connections) |
| 401 | } |
| 402 | if got.Bot.ToolApprovalMode != "workspace-write" || got.Bot.Connections[0].ToolApprovalMode != "workspace-write" { |
| 403 | t.Errorf("bot tool approval mode not migrated: bot=%q connection=%q", got.Bot.ToolApprovalMode, got.Bot.Connections[0].ToolApprovalMode) |
| 404 | } |
| 405 | if !got.Bot.Control.Enabled || got.Bot.Control.Addr != "127.0.0.1:39001" || got.Bot.Control.TokenEnv != "BOT_CONTROL_TOKEN" { |
| 406 | t.Errorf("bot control not preserved: %+v", got.Bot.Control) |
| 407 | } |
| 408 | if len(got.Bot.Feishu.OutboundMediaRoots) != 2 || got.Bot.Feishu.OutboundMediaRoots[0] != "/tmp/reasonix-media" { |
| 409 | t.Errorf("feishu outbound_media_roots not preserved: %+v", got.Bot.Feishu.OutboundMediaRoots) |
| 410 | } |
| 411 | if len(got.Bot.Routes) != 1 || got.Bot.Routes[0].WorkspaceRoot != "/tmp/reasonix-route" || got.Bot.Routes[0].ChatID != "oc_group" { |
| 412 | t.Errorf("bot routes not preserved: %+v", got.Bot.Routes) |
| 413 | } |
| 414 | if len(got.Bot.DesktopWatchers) != 1 || got.Bot.DesktopWatchers[0].ChatID != "oc_watcher" || got.Bot.DesktopWatchers[0].Platform != "feishu" || got.Bot.DesktopWatchers[0].Domain != "lark" { |
| 415 | t.Errorf("bot desktop watchers not preserved: %+v", got.Bot.DesktopWatchers) |
| 416 | } |
| 417 | if len(got.Bot.Connections[0].SessionMappings) != 1 || got.Bot.Connections[0].SessionMappings[0].Scope != "project" || got.Bot.Connections[0].SessionMappings[0].WorkspaceRoot != "/tmp/reasonix-bot" { |
| 418 | t.Errorf("bot session mapping scope not preserved: %+v", got.Bot.Connections[0].SessionMappings) |
| 419 | } |
| 420 | if got.Agent.Temperature != orig.Agent.Temperature { |
| 421 | t.Errorf("temperature = %v, want %v", got.Agent.Temperature, orig.Agent.Temperature) |
| 422 | } |
| 423 | if got.Agent.ReasoningLanguage != "zh" { |
| 424 | t.Errorf("reasoning_language = %q, want zh", got.Agent.ReasoningLanguage) |
| 425 | } |
| 426 | if got.Agent.CompactRatio != orig.Agent.CompactRatio { |
| 427 | t.Errorf("compact_ratio = %v, want %v", got.Agent.CompactRatio, orig.Agent.CompactRatio) |
| 428 | } |
| 429 | // Deprecated multi-threshold fields must not reappear after render/load. |
| 430 | if got.Agent.SoftCompactRatio != 0 || got.Agent.ToolResultSnipRatio != 0 || got.Agent.CompactForceRatio != 0 { |
| 431 | t.Errorf("deprecated compact ratios survived round-trip: soft=%v snip=%v force=%v", |
| 432 | got.Agent.SoftCompactRatio, got.Agent.ToolResultSnipRatio, got.Agent.CompactForceRatio) |
| 433 | } |
| 434 | if strings.Join(got.Agent.Keep, ",") != strings.Join(orig.Agent.Keep, ",") { |
| 435 | t.Errorf("keep = %v, want %v", got.Agent.Keep, orig.Agent.Keep) |
| 436 | } |
| 437 | if got.Agent.RecentKeep != orig.Agent.RecentKeep { |
| 438 | t.Errorf("recent_keep = %d, want %d", got.Agent.RecentKeep, orig.Agent.RecentKeep) |
| 439 | } |
| 440 | if got.Agent.SystemPrompt != orig.Agent.SystemPrompt { |
| 441 | t.Errorf("system_prompt mismatch:\n got %q\nwant %q", got.Agent.SystemPrompt, orig.Agent.SystemPrompt) |
| 442 | } |
| 443 | if !got.LSP.Enabled { |
| 444 | t.Error("lsp.enabled = false, want true") |
| 445 | } |
| 446 | if got.Environment.Enabled == nil || *got.Environment.Enabled { |
| 447 | t.Errorf("environment.enabled = %+v, want false", got.Environment.Enabled) |
| 448 | } |
| 449 | if !reflect.DeepEqual(got.Environment.Tools, orig.Environment.Tools) { |
| 450 | t.Errorf("environment.tools = %v, want %v", got.Environment.Tools, orig.Environment.Tools) |
| 451 | } |
| 452 | lua := got.LSP.Servers["lua"] |
| 453 | if lua.Command != "lua-language-server" || lua.LanguageID != "lua" || lua.InstallHint != "install lua-language-server" { |
| 454 | t.Errorf("lsp.servers.lua scalar fields not preserved: %+v", lua) |
| 455 | } |
| 456 | if len(lua.Args) != 1 || lua.Args[0] != "--stdio" { |
| 457 | t.Errorf("lsp.servers.lua.args = %v, want [--stdio]", lua.Args) |
| 458 | } |
| 459 | if lua.Env["LUA_PATH"] != "./?.lua" { |
| 460 | t.Errorf("lsp.servers.lua.env = %v, want LUA_PATH", lua.Env) |
| 461 | } |
| 462 | if len(lua.Extensions) != 3 || lua.Extensions[2] != ".gui_script" { |
| 463 | t.Errorf("lsp.servers.lua.extensions = %v", lua.Extensions) |
| 464 | } |
| 465 | if got.Agent.SubagentModel != "mimo-pro" { |
| 466 | t.Errorf("subagent_model = %q, want mimo-pro", got.Agent.SubagentModel) |
| 467 | } |
| 468 | if got.Agent.SubagentModels["review"] != "deepseek-pro" { |
| 469 | t.Errorf("subagent_models.review = %q, want deepseek-pro", got.Agent.SubagentModels["review"]) |
| 470 | } |
| 471 | if got.Agent.MaxSubagentDepth != 3 { |
| 472 | t.Errorf("max_subagent_depth = %d, want 3", got.Agent.MaxSubagentDepth) |
| 473 | } |
| 474 | if got.Tools.BashTimeoutSeconds == nil || *got.Tools.BashTimeoutSeconds != 900 { |
| 475 | t.Errorf("tools.bash_timeout_seconds = %v, want 900", got.Tools.BashTimeoutSeconds) |
| 476 | } |
| 477 | if got.Tools.BackgroundJobs.StalledWarningSeconds == nil || *got.Tools.BackgroundJobs.StalledWarningSeconds != 30 { |
| 478 | t.Errorf("tools.background_jobs.stalled_warning_seconds = %v, want 30", got.Tools.BackgroundJobs.StalledWarningSeconds) |
| 479 | } |
| 480 | if got.Tools.Shell.Prefer != "bash" { |
| 481 | t.Errorf("tools.shell.prefer = %q, want bash", got.Tools.Shell.Prefer) |
| 482 | } |
| 483 | if got.Tools.Shell.Path != "/usr/local/bin/bash" { |
| 484 | t.Errorf("tools.shell.path = %q, want /usr/local/bin/bash", got.Tools.Shell.Path) |
| 485 | } |
| 486 | if g, _ := got.Provider("mimo-pro"); g == nil || g.BaseURL != "http://localhost:8000/v1" || g.ChatURL != "http://localhost:8000/v1/chat/completions" || g.RequestURL != "http://localhost:8000/custom/chat/completions/?token=1" || g.ModelsURL != "http://localhost:8000/v1/models" || g.ReasoningProtocol != "openai" { |
| 487 | t.Errorf("mimo-pro endpoint fields not preserved: %+v", g) |
| 488 | } |
| 489 | if g, _ := got.Provider("mimo-pro"); g == nil || g.PresetID != "mimo-api" || g.PresetVersion != ProviderPresetVersion { |
| 490 | t.Errorf("mimo-pro preset metadata not preserved: %+v", g) |
| 491 | } |
| 492 | if g, _ := got.Provider("deepseek-flash"); g == nil || g.Effort != "max" { |
| 493 | t.Errorf("deepseek-flash effort not preserved: %+v", g) |
| 494 | } |
| 495 | if len(got.Providers) != len(orig.Providers) { |
| 496 | t.Errorf("providers count = %d, want %d", len(got.Providers), len(orig.Providers)) |
| 497 | } |
| 498 | if got.Permissions.Mode != "deny" { |
| 499 | t.Errorf("permissions.mode = %q, want deny", got.Permissions.Mode) |
| 500 | } |
| 501 | if len(got.Permissions.Deny) != 1 || got.Permissions.Deny[0] != "Bash(rm -rf*)" { |
| 502 | t.Errorf("permissions.deny = %v, want [Bash(rm -rf*)]", got.Permissions.Deny) |
| 503 | } |
| 504 | if len(got.Permissions.Allow) != 2 { |
| 505 | t.Errorf("permissions.allow = %v, want 2 entries", got.Permissions.Allow) |
| 506 | } |
| 507 | if got.Network.ProxyMode != "custom" || got.Network.Proxy.Type != "socks5" || got.Network.Proxy.Port != 7890 { |
| 508 | t.Errorf("network proxy not preserved: %+v", got.Network) |
| 509 | } |
| 510 | if len(got.Skills.Paths) != 2 || got.Skills.Paths[0] != "~/my-skills" { |
| 511 | t.Errorf("skills.paths = %v", got.Skills.Paths) |
| 512 | } |
| 513 | if len(got.Skills.ExcludedPaths) != 1 || got.Skills.ExcludedPaths[0] != "~/.agents/skills" { |
| 514 | t.Errorf("skills.excluded_paths = %v", got.Skills.ExcludedPaths) |
| 515 | } |
| 516 | if len(got.Skills.DisabledSkills) != 2 || got.Skills.DisabledSkills[0] != "review" || got.Skills.DisabledSkills[1] != "explore" { |
| 517 | t.Errorf("skills.disabled_skills = %v", got.Skills.DisabledSkills) |
| 518 | } |
| 519 | if !got.Skills.DisableImplicitInvocation || got.ImplicitSkillInvocationEnabled() { |
| 520 | t.Error("skills.disable_implicit_invocation was not preserved") |
| 521 | } |
| 522 | if got.SkillMaxDepth() != 2 { |
| 523 | t.Errorf("skills.max_depth = %d, want 2", got.SkillMaxDepth()) |
| 524 | } |
| 525 | if len(got.Plugins) != 2 { |
| 526 | t.Fatalf("plugins count = %d, want 2", len(got.Plugins)) |
| 527 | } |
| 528 | stripe := got.Plugins[1] |
| 529 | if stripe.Name != "stripe" || stripe.Type != "http" || stripe.URL != "https://mcp.stripe.com" { |
| 530 | t.Errorf("http plugin not preserved: %+v", stripe) |
| 531 | } |
| 532 | if stripe.Headers["Authorization"] != "Bearer x" { |
| 533 | t.Errorf("plugin headers not preserved: %v", stripe.Headers) |
| 534 | } |
| 535 | if strings.Contains(rendered, "trusted_read_only_tools") { |
| 536 | t.Errorf("removed plugin reader setting survived render: entry=%+v\n%s", stripe, rendered) |
| 537 | } |
| 538 | if stripe.AutoStart == nil || *stripe.AutoStart { |
| 539 | t.Errorf("auto_start should render and parse as false, got %+v", stripe.AutoStart) |
| 540 | } |
| 541 | if stripe.Tier != "" { |
| 542 | t.Errorf("plugin tier should be omitted from new config, got %q", stripe.Tier) |
| 543 | } |
| 544 | if strings.Contains(rendered, "\ntier") { |
| 545 | t.Errorf("rendered config should not contain MCP tier fields:\n%s", rendered) |
| 546 | } |
| 547 | } |
| 548 | |
| 549 | func TestRenderTOMLDocumentsPlanModeReadOnlyCommands(t *testing.T) { |
| 550 | cfg := Default() |
| 551 | cfg.Agent.PlanModeReadOnlyCommands = []string{"gh issue view"} |
| 552 | |
| 553 | rendered := RenderTOML(cfg) |
| 554 | var got Config |
| 555 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 556 | t.Fatalf("rendered TOML does not parse: %v\n%s", err, rendered) |
| 557 | } |
| 558 | if !strings.Contains(rendered, `plan_mode_read_only_commands = ["gh issue view"]`) { |
| 559 | t.Fatalf("rendered config should preserve plan_mode_read_only_commands:\n%s", rendered) |
| 560 | } |
| 561 | if !strings.Contains(rendered, "legacy compatibility only") || !strings.Contains(rendered, "Plan bash uses Permissions") { |
| 562 | t.Fatalf("rendered config should document legacy plan_mode_read_only_commands semantics:\n%s", rendered) |
| 563 | } |
| 564 | if !reflect.DeepEqual(got.Agent.PlanModeReadOnlyCommands, cfg.Agent.PlanModeReadOnlyCommands) { |
| 565 | t.Fatalf("PlanModeReadOnlyCommands round trip = %v, want %v", got.Agent.PlanModeReadOnlyCommands, cfg.Agent.PlanModeReadOnlyCommands) |
| 566 | } |
| 567 | } |
| 568 | |
| 569 | func TestRenderTOMLDropsRetiredMCPPolicyFields(t *testing.T) { |
| 570 | var cfg Config |
| 571 | if _, err := toml.Decode(`[[plugins]] |
| 572 | name = "github" |
| 573 | command = "github-mcp" |
| 574 | trusted_read_only_tools = ["issue_read", "pull_request_read"] |
| 575 | default_tools_approval_mode = "writes" |
| 576 | approvals_reviewer = "auto_review" |
| 577 | |
| 578 | [plugins.tools.wipe] |
| 579 | approval_mode = "prompt" |
| 580 | `, &cfg); err != nil { |
| 581 | t.Fatalf("legacy config should still decode: %v", err) |
| 582 | } |
| 583 | |
| 584 | rendered := RenderTOML(&cfg) |
| 585 | for _, retired := range []string{"trusted_read_only_tools", "default_tools_approval_mode", "approvals_reviewer", "\napproval_mode ="} { |
| 586 | if strings.Contains(rendered, retired) { |
| 587 | t.Fatalf("rendered config retained retired MCP field %q:\n%s", retired, rendered) |
| 588 | } |
| 589 | } |
| 590 | |
| 591 | var got Config |
| 592 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 593 | t.Fatalf("rendered TOML does not parse: %v\n%s", err, rendered) |
| 594 | } |
| 595 | } |
| 596 | |
| 597 | func TestRenderTOMLPreservesMCPTimeouts(t *testing.T) { |
| 598 | cfg := Default() |
| 599 | cfg.Tools.MCPCallTimeoutSeconds = intPtr(450) |
| 600 | cfg.Tools.MCPStartupTimeoutSeconds = intPtr(45) |
| 601 | cfg.Plugins = []PluginEntry{{ |
| 602 | Name: "maker", |
| 603 | Command: "maker-mcp", |
| 604 | StartupTimeoutSeconds: 60, |
| 605 | CallTimeoutSeconds: 600, |
| 606 | ToolTimeoutSeconds: map[string]int{ |
| 607 | "generate/video": 1800, |
| 608 | "search": 120, |
| 609 | }, |
| 610 | }} |
| 611 | |
| 612 | rendered := RenderTOML(cfg) |
| 613 | for _, want := range []string{ |
| 614 | "mcp_call_timeout_seconds = 450", |
| 615 | "mcp_startup_timeout_seconds = 45", |
| 616 | "startup_timeout_seconds = 60", |
| 617 | "call_timeout_seconds = 600", |
| 618 | `tool_timeout_seconds = { "generate/video" = 1800, "search" = 120 }`, |
| 619 | "Raw MCP tool names", |
| 620 | } { |
| 621 | if !strings.Contains(rendered, want) { |
| 622 | t.Fatalf("rendered config missing %q:\n%s", want, rendered) |
| 623 | } |
| 624 | } |
| 625 | |
| 626 | var got Config |
| 627 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 628 | t.Fatalf("rendered TOML does not parse: %v\n%s", err, rendered) |
| 629 | } |
| 630 | if got.Tools.MCPCallTimeoutSeconds == nil || *got.Tools.MCPCallTimeoutSeconds != 450 { |
| 631 | t.Fatalf("MCPCallTimeoutSeconds round trip = %v, want 450", got.Tools.MCPCallTimeoutSeconds) |
| 632 | } |
| 633 | if got.Tools.MCPStartupTimeoutSeconds == nil || *got.Tools.MCPStartupTimeoutSeconds != 45 { |
| 634 | t.Fatalf("MCPStartupTimeoutSeconds round trip = %v, want 45", got.Tools.MCPStartupTimeoutSeconds) |
| 635 | } |
| 636 | if got.Plugins[0].StartupTimeoutSeconds != 60 { |
| 637 | t.Fatalf("StartupTimeoutSeconds round trip = %d, want 60", got.Plugins[0].StartupTimeoutSeconds) |
| 638 | } |
| 639 | if got.Plugins[0].CallTimeoutSeconds != 600 { |
| 640 | t.Fatalf("CallTimeoutSeconds round trip = %d, want 600", got.Plugins[0].CallTimeoutSeconds) |
| 641 | } |
| 642 | if !reflect.DeepEqual(got.Plugins[0].ToolTimeoutSeconds, cfg.Plugins[0].ToolTimeoutSeconds) { |
| 643 | t.Fatalf("ToolTimeoutSeconds round trip = %v, want %v", got.Plugins[0].ToolTimeoutSeconds, cfg.Plugins[0].ToolTimeoutSeconds) |
| 644 | } |
| 645 | } |
| 646 | |
| 647 | func TestRenderTOMLCreationLayoutStyle(t *testing.T) { |
| 648 | c := Default() |
| 649 | if err := c.SetDesktopLayoutStyle("creation"); err != nil { |
| 650 | t.Fatalf("SetDesktopLayoutStyle: %v", err) |
| 651 | } |
| 652 | rendered := RenderTOML(c) |
| 653 | var got Config |
| 654 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 655 | t.Fatalf("rendered TOML does not parse: %v\n---\n%s", err, rendered) |
| 656 | } |
| 657 | if got.Desktop.LayoutStyle != "creation" { |
| 658 | t.Errorf("desktop.layout_style = %q, want creation", got.Desktop.LayoutStyle) |
| 659 | } |
| 660 | if got.DesktopLayoutStyle() != "creation" { |
| 661 | t.Errorf("DesktopLayoutStyle() = %q, want creation", got.DesktopLayoutStyle()) |
| 662 | } |
| 663 | } |
| 664 | |
| 665 | func TestScopedRenderPreservesLSPConfig(t *testing.T) { |
| 666 | const src = ` |
| 667 | config_version = 4 |
| 668 | default_model = "mimo" |
| 669 | |
| 670 | [lsp] |
| 671 | enabled = true |
| 672 | |
| 673 | [lsp.servers.lua] |
| 674 | command = "lua-language-server" |
| 675 | args = ["--stdio"] |
| 676 | env = { LUA_PATH = "./?.lua" } |
| 677 | language_id = "lua" |
| 678 | extensions = [".lua", ".script", ".gui_script"] |
| 679 | install_hint = "install lua-language-server" |
| 680 | |
| 681 | [lsp.servers."c++"] |
| 682 | command = "clangd" |
| 683 | extensions = [".cc", ".cpp", ".hpp"] |
| 684 | ` |
| 685 | |
| 686 | var cfg Config |
| 687 | if _, err := toml.Decode(src, &cfg); err != nil { |
| 688 | t.Fatalf("decode source TOML: %v", err) |
| 689 | } |
| 690 | |
| 691 | for _, scope := range []RenderScope{RenderScopeFull, RenderScopeUser, RenderScopeProject} { |
| 692 | t.Run(string(scope), func(t *testing.T) { |
| 693 | rendered := RenderTOMLForScope(&cfg, scope) |
| 694 | if !strings.Contains(rendered, "[lsp]") { |
| 695 | t.Fatalf("render missing [lsp]:\n%s", rendered) |
| 696 | } |
| 697 | if !strings.Contains(rendered, "[lsp.servers.lua]") { |
| 698 | t.Fatalf("render missing [lsp.servers.lua]:\n%s", rendered) |
| 699 | } |
| 700 | if !strings.Contains(rendered, `[lsp.servers."c++"]`) { |
| 701 | t.Fatalf("render missing quoted c++ server key:\n%s", rendered) |
| 702 | } |
| 703 | |
| 704 | var got Config |
| 705 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 706 | t.Fatalf("decode rendered TOML: %v\n---\n%s", err, rendered) |
| 707 | } |
| 708 | if !got.LSP.Enabled { |
| 709 | t.Fatalf("lsp.enabled = false, want true") |
| 710 | } |
| 711 | lua, ok := got.LSP.Servers["lua"] |
| 712 | if !ok { |
| 713 | t.Fatalf("lsp.servers.lua missing after round-trip: %+v", got.LSP.Servers) |
| 714 | } |
| 715 | if lua.Command != "lua-language-server" || lua.LanguageID != "lua" || lua.InstallHint != "install lua-language-server" { |
| 716 | t.Fatalf("lsp.servers.lua scalar fields not preserved: %+v", lua) |
| 717 | } |
| 718 | if len(lua.Args) != 1 || lua.Args[0] != "--stdio" { |
| 719 | t.Fatalf("lsp.servers.lua.args = %v, want [--stdio]", lua.Args) |
| 720 | } |
| 721 | if lua.Env["LUA_PATH"] != "./?.lua" { |
| 722 | t.Fatalf("lsp.servers.lua.env = %v, want LUA_PATH", lua.Env) |
| 723 | } |
| 724 | if len(lua.Extensions) != 3 || lua.Extensions[0] != ".lua" || lua.Extensions[2] != ".gui_script" { |
| 725 | t.Fatalf("lsp.servers.lua.extensions = %v", lua.Extensions) |
| 726 | } |
| 727 | cpp, ok := got.LSP.Servers["c++"] |
| 728 | if !ok { |
| 729 | t.Fatalf("lsp.servers.c++ missing after round-trip: %+v", got.LSP.Servers) |
| 730 | } |
| 731 | if cpp.Command != "clangd" || len(cpp.Extensions) != 3 || cpp.Extensions[1] != ".cpp" { |
| 732 | t.Fatalf("lsp.servers.c++ not preserved: %+v", cpp) |
| 733 | } |
| 734 | }) |
| 735 | } |
| 736 | } |
| 737 | |
| 738 | func BenchmarkRenderTOMLWithLSPServers(b *testing.B) { |
| 739 | cfg := Default() |
| 740 | cfg.LSP.Servers = make(map[string]LSPServer, 64) |
| 741 | for i := range 64 { |
| 742 | lang := "lang" + strconv.Itoa(i) |
| 743 | cfg.LSP.Servers[lang] = LSPServer{ |
| 744 | Command: "server-" + strconv.Itoa(i), |
| 745 | Args: []string{"--stdio", "--flag"}, |
| 746 | Env: map[string]string{"SERVER_MODE": "stdio", "SERVER_ROOT": "."}, |
| 747 | LanguageID: lang, |
| 748 | Extensions: []string{"." + lang, "." + lang + "x"}, |
| 749 | InstallHint: "install server-" + strconv.Itoa(i), |
| 750 | } |
| 751 | } |
| 752 | |
| 753 | b.ReportAllocs() |
| 754 | for range b.N { |
| 755 | rendered := RenderTOML(cfg) |
| 756 | if len(rendered) == 0 { |
| 757 | b.Fatal("empty render") |
| 758 | } |
| 759 | } |
| 760 | } |
| 761 | |
| 762 | func TestNotificationsDefaultsKeepEventSwitchesEnabled(t *testing.T) { |
| 763 | cfg := Default() |
| 764 | if cfg.Notifications.Enabled { |
| 765 | t.Fatal("notifications.enabled default = true, want false") |
| 766 | } |
| 767 | if !cfg.Notifications.TurnDone || !cfg.Notifications.ApprovalRequest || !cfg.Notifications.AskRequest { |
| 768 | t.Fatalf("notification event switches default off: %+v", cfg.Notifications) |
| 769 | } |
| 770 | |
| 771 | if _, err := toml.Decode("[notifications]\nenabled = true\n", cfg); err != nil { |
| 772 | t.Fatalf("decode notifications: %v", err) |
| 773 | } |
| 774 | if !cfg.Notifications.Enabled || !cfg.Notifications.TurnDone || !cfg.Notifications.ApprovalRequest || !cfg.Notifications.AskRequest { |
| 775 | t.Fatalf("enabled-only config should keep event switches on: %+v", cfg.Notifications) |
| 776 | } |
| 777 | } |
| 778 | |
| 779 | func TestScopedRenderKeepsPluginsInTheirOwningConfig(t *testing.T) { |
| 780 | cfg := Default() |
| 781 | cfg.Plugins = []PluginEntry{ |
| 782 | {Name: "unknown", Command: "unknown-mcp"}, |
| 783 | {Name: "user", Command: "user-mcp", Source: MCPSourceUserConfig}, |
| 784 | {Name: "project", Command: "project-mcp", Source: MCPSourceProjectConfig}, |
| 785 | {Name: "mcp-json", Command: "json-mcp", Source: MCPSourceProjectMCPJSON}, |
| 786 | {Name: "legacy", Command: "legacy-mcp", Source: MCPSourceLegacyUser}, |
| 787 | {Name: "package", Command: "package-mcp", Source: MCPSourcePluginPackage}, |
| 788 | } |
| 789 | |
| 790 | tests := []struct { |
| 791 | name string |
| 792 | body string |
| 793 | want []string |
| 794 | avoid []string |
| 795 | }{ |
| 796 | {name: "full", body: RenderTOMLForScope(cfg, RenderScopeFull), want: []string{"unknown", "user", "project", "mcp-json", "legacy", "package"}}, |
| 797 | {name: "user", body: RenderTOMLForScope(cfg, RenderScopeUser), want: []string{"unknown", "user"}, avoid: []string{"project", "mcp-json", "legacy", "package"}}, |
| 798 | {name: "project", body: RenderTOMLForScope(cfg, RenderScopeProject), want: []string{"unknown", "project"}, avoid: []string{"user", "mcp-json", "legacy", "package"}}, |
| 799 | {name: "project delta", body: RenderTOMLProjectDelta(cfg), want: []string{"unknown", "project"}, avoid: []string{"user", "mcp-json", "legacy", "package"}}, |
| 800 | } |
| 801 | for _, tt := range tests { |
| 802 | t.Run(tt.name, func(t *testing.T) { |
| 803 | for _, name := range tt.want { |
| 804 | if !strings.Contains(tt.body, `name = "`+name+`"`) { |
| 805 | t.Fatalf("render missing plugin %q:\n%s", name, tt.body) |
| 806 | } |
| 807 | } |
| 808 | for _, name := range tt.avoid { |
| 809 | if strings.Contains(tt.body, `name = "`+name+`"`) { |
| 810 | t.Fatalf("render leaked plugin %q:\n%s", name, tt.body) |
| 811 | } |
| 812 | } |
| 813 | }) |
| 814 | } |
| 815 | } |
| 816 | |
| 817 | func TestProjectDeltaOmitsRetiredRecoveryReviewerOverride(t *testing.T) { |
| 818 | c := Default() |
| 819 | c.Agent.RecoveryModel = "deepseek-pro" |
| 820 | c.Agent.RecoveryTemperature = 0.2 |
| 821 | |
| 822 | delta := RenderTOMLProjectDelta(c) |
| 823 | if strings.Contains(delta, "recovery_model") { |
| 824 | t.Fatalf("retired recovery_model rendered:\n%s", delta) |
| 825 | } |
| 826 | if strings.Contains(delta, "recovery_temperature") { |
| 827 | t.Fatalf("deprecated recovery_temperature rendered:\n%s", delta) |
| 828 | } |
| 829 | } |
| 830 | |
| 831 | func TestProjectDeltaRendersToolsShellOverrides(t *testing.T) { |
| 832 | c := Default() |
| 833 | c.Tools.Shell.Prefer = "bash" |
| 834 | c.Tools.Shell.Path = "/usr/local/bin/bash" |
| 835 | |
| 836 | delta := RenderTOMLProjectDelta(c) |
| 837 | for _, want := range []string{"[tools.shell]", `prefer = "bash"`, `path = "/usr/local/bin/bash"`} { |
| 838 | if !strings.Contains(delta, want) { |
| 839 | t.Fatalf("project delta missing %q:\n%s", want, delta) |
| 840 | } |
| 841 | } |
| 842 | if strings.Contains(delta, "[tools]\n\n") { |
| 843 | t.Fatalf("project delta should not emit an empty [tools] block:\n%s", delta) |
| 844 | } |
| 845 | |
| 846 | got := Default() |
| 847 | if _, err := toml.Decode(delta, got); err != nil { |
| 848 | t.Fatalf("decode project delta: %v\n%s", err, delta) |
| 849 | } |
| 850 | if got.Tools.Shell.Prefer != "bash" || got.Tools.Shell.Path != "/usr/local/bin/bash" { |
| 851 | t.Fatalf("tools.shell = %+v, want bash with path", got.Tools.Shell) |
| 852 | } |
| 853 | } |
| 854 | |
| 855 | func TestResponsesProviderModeRoundTripsInUserAndProjectRender(t *testing.T) { |
| 856 | legacyFalse := false |
| 857 | cfg := Default() |
| 858 | cfg.Providers = append(cfg.Providers, ProviderEntry{ |
| 859 | Name: "responses-test", Kind: "responses", BaseURL: "https://example.com/v1", |
| 860 | ChatURL: "https://legacy.example.com/chat/completions", RequestURL: "https://example.com/v1/custom/responses", |
| 861 | Model: "model", APIKeyEnv: "RESPONSES_API_KEY", |
| 862 | ResponsesMode: "stateful", ResponsesStateful: &legacyFalse, |
| 863 | }) |
| 864 | |
| 865 | for _, rendered := range []string{RenderTOMLForScope(cfg, RenderScopeUser), RenderTOMLProjectDelta(cfg)} { |
| 866 | if !strings.Contains(rendered, `responses_mode = "stateful"`) || !strings.Contains(rendered, "responses_stateful = false") { |
| 867 | t.Fatalf("responses settings missing from render:\n%s", rendered) |
| 868 | } |
| 869 | var decoded Config |
| 870 | if _, err := toml.Decode(rendered, &decoded); err != nil { |
| 871 | t.Fatalf("decode responses config: %v\n%s", err, rendered) |
| 872 | } |
| 873 | entry, ok := decoded.Provider("responses-test") |
| 874 | if !ok || entry.ChatURL != "https://legacy.example.com/chat/completions" || entry.RequestURL != "https://example.com/v1/custom/responses" || entry.ResponsesMode != "stateful" || entry.ResponsesStateful == nil || *entry.ResponsesStateful { |
| 875 | t.Fatalf("responses settings did not round-trip: %+v, found=%v", entry, ok) |
| 876 | } |
| 877 | } |
| 878 | } |
| 879 | |
| 880 | func TestProjectDeltaRendersUICursorShape(t *testing.T) { |
| 881 | c := Default() |
| 882 | c.UI.CursorShape = "block" |
| 883 | |
| 884 | delta := RenderTOMLProjectDelta(c) |
| 885 | for _, want := range []string{"[ui]", `cursor_shape = "block"`} { |
| 886 | if !strings.Contains(delta, want) { |
| 887 | t.Fatalf("project delta missing %q:\n%s", want, delta) |
| 888 | } |
| 889 | } |
| 890 | |
| 891 | got := Default() |
| 892 | if _, err := toml.Decode(delta, got); err != nil { |
| 893 | t.Fatalf("decode project delta: %v\n%s", err, delta) |
| 894 | } |
| 895 | if got.UICursorShape() != "block" { |
| 896 | t.Fatalf("ui.cursor_shape = %q, want block", got.UICursorShape()) |
| 897 | } |
| 898 | } |
| 899 | |
| 900 | func TestShowTurnUsageDefaultsOnAndRendersFalseOverride(t *testing.T) { |
| 901 | c := Default() |
| 902 | if !c.UI.ShowTurnUsage { |
| 903 | t.Fatal("ui.show_turn_usage should default to true") |
| 904 | } |
| 905 | |
| 906 | c.UI.ShowTurnUsage = false |
| 907 | delta := RenderTOMLProjectDelta(c) |
| 908 | for _, want := range []string{"[ui]", "show_turn_usage = false"} { |
| 909 | if !strings.Contains(delta, want) { |
| 910 | t.Fatalf("project delta missing %q:\n%s", want, delta) |
| 911 | } |
| 912 | } |
| 913 | |
| 914 | got := Default() |
| 915 | if _, err := toml.Decode(delta, got); err != nil { |
| 916 | t.Fatalf("decode project delta: %v\n%s", err, delta) |
| 917 | } |
| 918 | if got.UI.ShowTurnUsage { |
| 919 | t.Fatal("ui.show_turn_usage false override did not round-trip") |
| 920 | } |
| 921 | } |
| 922 | |
| 923 | func TestProjectRenderPreservesNonDefaultLegacySections(t *testing.T) { |
| 924 | c := Default() |
| 925 | c.UI.Theme = "light" |
| 926 | c.UI.CloseBehavior = "quit" |
| 927 | c.Network.ProxyMode = "custom" |
| 928 | c.Network.Proxy.Server = "127.0.0.1" |
| 929 | c.Network.Proxy.Port = 7890 |
| 930 | |
| 931 | project := RenderTOMLForScope(c, RenderScopeProject) |
| 932 | for _, want := range []string{"[ui]", `theme = "light"`, `close_behavior = "quit"`, "[network]", `proxy_mode = "custom"`, `server = "127.0.0.1"`} { |
| 933 | if !strings.Contains(project, want) { |
| 934 | t.Fatalf("project render missing legacy/non-default %q:\n%s", want, project) |
| 935 | } |
| 936 | } |
| 937 | } |
| 938 | |
| 939 | func TestRenderTOMLRoundTripsPerModelPrices(t *testing.T) { |
| 940 | orig := Default() |
| 941 | orig.Providers = []ProviderEntry{{ |
| 942 | Name: "deepseek", |
| 943 | Kind: "openai", |
| 944 | BaseURL: "https://api.deepseek.com", |
| 945 | Models: []string{"deepseek-v4-flash", "deepseek-v4-pro"}, |
| 946 | Default: "deepseek-v4-flash", |
| 947 | APIKeyEnv: "DEEPSEEK_API_KEY", |
| 948 | Prices: DeepSeekV4PricesForCurrency("CNY"), |
| 949 | }} |
| 950 | |
| 951 | var got Config |
| 952 | if _, err := toml.Decode(RenderTOML(orig), &got); err != nil { |
| 953 | t.Fatalf("rendered TOML does not parse: %v", err) |
| 954 | } |
| 955 | p, ok := got.Provider("deepseek") |
| 956 | if !ok { |
| 957 | t.Fatal("deepseek provider missing after round trip") |
| 958 | } |
| 959 | if p.Prices["deepseek-v4-flash"].Input != 2 || p.Prices["deepseek-v4-pro"].Output != 27 { |
| 960 | t.Fatalf("prices after round trip = %+v", p.Prices) |
| 961 | } |
| 962 | } |
| 963 | |
| 964 | func TestRenderTOMLRoundTripsVisionModels(t *testing.T) { |
| 965 | orig := Default() |
| 966 | orig.Providers = []ProviderEntry{ |
| 967 | { |
| 968 | Name: "custom", |
| 969 | Kind: "openai", |
| 970 | BaseURL: "https://proxy.example.com/v1", |
| 971 | Models: []string{"text-only", "qwen-vl-plus"}, |
| 972 | Default: "text-only", |
| 973 | APIKeyEnv: "CUSTOM_API_KEY", |
| 974 | VisionModels: []string{"qwen-vl-plus"}, |
| 975 | VisionDetail: "low", |
| 976 | }, |
| 977 | { |
| 978 | Name: "disabled-vision", |
| 979 | Kind: "openai", |
| 980 | BaseURL: "https://proxy.example.com/v1", |
| 981 | Models: []string{"qwen-vl-plus"}, |
| 982 | Default: "qwen-vl-plus", |
| 983 | APIKeyEnv: "CUSTOM_API_KEY", |
| 984 | VisionModels: []string{}, |
| 985 | }, |
| 986 | } |
| 987 | |
| 988 | rendered := RenderTOML(orig) |
| 989 | if !strings.Contains(rendered, `vision_models = ["qwen-vl-plus"]`) { |
| 990 | t.Fatalf("rendered TOML missing vision_models:\n%s", rendered) |
| 991 | } |
| 992 | if !strings.Contains(rendered, `vision_models = []`) { |
| 993 | t.Fatalf("rendered TOML missing explicit empty vision_models:\n%s", rendered) |
| 994 | } |
| 995 | if !strings.Contains(rendered, `vision_detail = "low"`) { |
| 996 | t.Fatalf("rendered TOML missing vision_detail:\n%s", rendered) |
| 997 | } |
| 998 | |
| 999 | var got Config |
| 1000 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 1001 | t.Fatalf("rendered TOML does not parse: %v", err) |
| 1002 | } |
| 1003 | p, ok := got.Provider("custom") |
| 1004 | if !ok { |
| 1005 | t.Fatal("custom provider missing after round trip") |
| 1006 | } |
| 1007 | if !reflect.DeepEqual(p.VisionModels, []string{"qwen-vl-plus"}) { |
| 1008 | t.Fatalf("vision_models after round trip = %v, want [qwen-vl-plus]", p.VisionModels) |
| 1009 | } |
| 1010 | if p.VisionDetail != "low" { |
| 1011 | t.Fatalf("vision_detail after round trip = %q, want low", p.VisionDetail) |
| 1012 | } |
| 1013 | disabled, ok := got.Provider("disabled-vision") |
| 1014 | if !ok { |
| 1015 | t.Fatal("disabled-vision provider missing after round trip") |
| 1016 | } |
| 1017 | if disabled.VisionModels == nil || len(disabled.VisionModels) != 0 { |
| 1018 | t.Fatalf("disabled-vision vision_models after round trip = %#v, want explicit empty list", disabled.VisionModels) |
| 1019 | } |
| 1020 | } |
| 1021 | |
| 1022 | func TestRenderTOMLRoundTripsProviderHeadersAndModelOverrides(t *testing.T) { |
| 1023 | orig := Default() |
| 1024 | orig.Providers = []ProviderEntry{{ |
| 1025 | Name: "gateway", |
| 1026 | Kind: "openai", |
| 1027 | BaseURL: "https://gateway.example/v1", |
| 1028 | Models: []string{"deepseek-v4-flash", "plain-chat"}, |
| 1029 | Default: "plain-chat", |
| 1030 | APIKeyEnv: "GATEWAY_API_KEY", |
| 1031 | Headers: map[string]string{ |
| 1032 | "HTTP-Referer": "https://app.example", |
| 1033 | "X-Title": "Reasonix", |
| 1034 | }, |
| 1035 | ExtraBody: map[string]any{ |
| 1036 | "enable_thinking": true, |
| 1037 | "top_p": 0.8, |
| 1038 | "metadata": map[string]any{ |
| 1039 | "mode": "fast", |
| 1040 | }, |
| 1041 | }, |
| 1042 | AuthHeader: true, |
| 1043 | MaxOutputTokens: 16_384, |
| 1044 | ModelOverrides: map[string]ProviderModelOverride{ |
| 1045 | "deepseek-v4-flash": { |
| 1046 | ReasoningProtocol: ReasoningProtocolDeepSeek, |
| 1047 | SupportedEfforts: []string{"high", "max"}, |
| 1048 | DefaultEffort: "high", |
| 1049 | Vision: boolPtr(false), |
| 1050 | ContextWindow: 262_144, |
| 1051 | MaxOutputTokens: 32_768, |
| 1052 | }, |
| 1053 | }, |
| 1054 | }} |
| 1055 | |
| 1056 | rendered := RenderTOML(orig) |
| 1057 | if !strings.Contains(rendered, `headers = { HTTP-Referer = "https://app.example", X-Title = "Reasonix" }`) { |
| 1058 | t.Fatalf("rendered TOML missing headers:\n%s", rendered) |
| 1059 | } |
| 1060 | if !strings.Contains(rendered, `extra_body`) || !strings.Contains(rendered, `"enable_thinking" = true`) { |
| 1061 | t.Fatalf("rendered TOML missing extra_body:\n%s", rendered) |
| 1062 | } |
| 1063 | if !strings.Contains(rendered, `auth_header = true`) { |
| 1064 | t.Fatalf("rendered TOML missing auth_header:\n%s", rendered) |
| 1065 | } |
| 1066 | if !strings.Contains(rendered, `max_output_tokens = 16384`) || !strings.Contains(rendered, `model_overrides`) || !strings.Contains(rendered, `reasoning_protocol = "deepseek"`) || !strings.Contains(rendered, `context_window = 262144`) || !strings.Contains(rendered, `max_output_tokens = 32768`) { |
| 1067 | t.Fatalf("rendered TOML missing model overrides:\n%s", rendered) |
| 1068 | } |
| 1069 | |
| 1070 | var got Config |
| 1071 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 1072 | t.Fatalf("rendered TOML does not parse: %v\n%s", err, rendered) |
| 1073 | } |
| 1074 | p, ok := got.Provider("gateway") |
| 1075 | if !ok { |
| 1076 | t.Fatal("gateway provider missing after round trip") |
| 1077 | } |
| 1078 | if p.Headers["HTTP-Referer"] != "https://app.example" || p.Headers["X-Title"] != "Reasonix" { |
| 1079 | t.Fatalf("headers after round trip = %+v", p.Headers) |
| 1080 | } |
| 1081 | if p.ExtraBody["enable_thinking"] != true || p.ExtraBody["top_p"] != 0.8 { |
| 1082 | t.Fatalf("extra_body after round trip = %+v", p.ExtraBody) |
| 1083 | } |
| 1084 | if !p.AuthHeader { |
| 1085 | t.Fatal("auth_header after round trip = false, want true") |
| 1086 | } |
| 1087 | if p.MaxOutputTokens != 16_384 { |
| 1088 | t.Fatalf("provider max_output_tokens after round trip = %d, want 16384", p.MaxOutputTokens) |
| 1089 | } |
| 1090 | metadata, ok := p.ExtraBody["metadata"].(map[string]any) |
| 1091 | if !ok || metadata["mode"] != "fast" { |
| 1092 | t.Fatalf("extra_body metadata after round trip = %+v", p.ExtraBody["metadata"]) |
| 1093 | } |
| 1094 | ov := p.ModelOverrides["deepseek-v4-flash"] |
| 1095 | if ov.ReasoningProtocol != ReasoningProtocolDeepSeek || !reflect.DeepEqual(ov.SupportedEfforts, []string{"high", "max"}) || ov.DefaultEffort != "high" || ov.Vision == nil || *ov.Vision || ov.ContextWindow != 262_144 || ov.MaxOutputTokens != 32_768 { |
| 1096 | t.Fatalf("model override after round trip = %+v", ov) |
| 1097 | } |
| 1098 | |
| 1099 | // Older releases do not know context_window/max_output_tokens inside model |
| 1100 | // overrides, but their TOML decoder must still accept this release's config. |
| 1101 | type legacyModelOverride struct { |
| 1102 | ReasoningProtocol string `toml:"reasoning_protocol"` |
| 1103 | SupportedEfforts []string `toml:"supported_efforts"` |
| 1104 | DefaultEffort string `toml:"default_effort"` |
| 1105 | Vision *bool `toml:"vision"` |
| 1106 | } |
| 1107 | type legacyProvider struct { |
| 1108 | ModelOverrides map[string]legacyModelOverride `toml:"model_overrides"` |
| 1109 | } |
| 1110 | var legacy struct { |
| 1111 | Providers []legacyProvider `toml:"providers"` |
| 1112 | } |
| 1113 | if _, err := toml.Decode(rendered, &legacy); err != nil { |
| 1114 | t.Fatalf("legacy config shape cannot read per-model context window: %v", err) |
| 1115 | } |
| 1116 | } |
| 1117 | |
| 1118 | func TestRenderStringMapQuotesNonBareTOMLKeys(t *testing.T) { |
| 1119 | rendered := renderStringMap(map[string]string{ |
| 1120 | "github:gh-fix-ci": "deepseek-pro", |
| 1121 | "review": "deepseek-flash", |
| 1122 | }) |
| 1123 | if !strings.Contains(rendered, `"github:gh-fix-ci" = "deepseek-pro"`) { |
| 1124 | t.Fatalf("non-bare key was not quoted: %s", rendered) |
| 1125 | } |
| 1126 | var got struct { |
| 1127 | M map[string]string `toml:"m"` |
| 1128 | } |
| 1129 | if _, err := toml.Decode("m = "+rendered, &got); err != nil { |
| 1130 | t.Fatalf("rendered inline map does not parse: %v (%s)", err, rendered) |
| 1131 | } |
| 1132 | if got.M["github:gh-fix-ci"] != "deepseek-pro" || got.M["review"] != "deepseek-flash" { |
| 1133 | t.Fatalf("decoded map = %+v", got.M) |
| 1134 | } |
| 1135 | } |
| 1136 | |
| 1137 | func TestDesktopExternalOpenerUserScopeRoundTrip(t *testing.T) { |
| 1138 | cfg := Default() |
| 1139 | if err := cfg.SetDesktopExternalOpener("ghostty"); err != nil { |
| 1140 | t.Fatal(err) |
| 1141 | } |
| 1142 | rendered := RenderTOMLForScope(cfg, RenderScopeUser) |
| 1143 | if !strings.Contains(rendered, `external_opener = "ghostty"`) { |
| 1144 | t.Fatalf("user config omitted desktop external opener:\n%s", rendered) |
| 1145 | } |
| 1146 | if project := RenderTOMLForScope(cfg, RenderScopeProject); strings.Contains(project, "external_opener") { |
| 1147 | t.Fatalf("project config leaked user-only external opener:\n%s", project) |
| 1148 | } |
| 1149 | var decoded Config |
| 1150 | if _, err := toml.Decode(rendered, &decoded); err != nil { |
| 1151 | t.Fatalf("decode rendered user config: %v", err) |
| 1152 | } |
| 1153 | if got := decoded.DesktopExternalOpener(); got != "ghostty" { |
| 1154 | t.Fatalf("round-trip external opener = %q, want ghostty", got) |
| 1155 | } |
| 1156 | } |
| 1157 | |
| 1158 | func TestRenderTOMLTablePathQuotesEachSegment(t *testing.T) { |
| 1159 | got := renderTOMLTablePath("lsp", "servers", "c++", "github:gh-fix-ci") |
| 1160 | want := `lsp.servers."c++"."github:gh-fix-ci"` |
| 1161 | if got != want { |
| 1162 | t.Fatalf("renderTOMLTablePath = %q, want %q", got, want) |
| 1163 | } |
| 1164 | } |
| 1165 | |
| 1166 | func boolPtr(v bool) *bool { return &v } |
| 1167 | |
| 1168 | func intPtr(v int) *int { return &v } |
| 1169 | |
| 1170 | func TestRenderTOMLPreservesDesktopDisplayMode(t *testing.T) { |
| 1171 | c := Default() |
| 1172 | if err := c.SetDesktopDisplayMode("compact"); err != nil { |
| 1173 | t.Fatalf("SetDesktopDisplayMode: %v", err) |
| 1174 | } |
| 1175 | rendered := RenderTOMLForScope(c, RenderScopeUser) |
| 1176 | if !strings.Contains(rendered, `display_mode = "compact"`) { |
| 1177 | t.Fatalf("rendered user config missing display_mode:\n%s", rendered) |
| 1178 | } |
| 1179 | var got Config |
| 1180 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 1181 | t.Fatalf("rendered TOML does not parse: %v\n---\n%s", err, rendered) |
| 1182 | } |
| 1183 | if got.DesktopDisplayMode() != "compact" { |
| 1184 | t.Fatalf("display_mode after round trip = %q, want compact", got.DesktopDisplayMode()) |
| 1185 | } |
| 1186 | } |
| 1187 | |
| 1188 | func TestRenderTOMLConversationWidthRoundTrip(t *testing.T) { |
| 1189 | c := Default() |
| 1190 | if err := c.SetDesktopConversationWidth("full"); err != nil { |
| 1191 | t.Fatalf("SetDesktopConversationWidth: %v", err) |
| 1192 | } |
| 1193 | rendered := RenderTOMLForScope(c, RenderScopeUser) |
| 1194 | if !strings.Contains(rendered, `conversation_width = "full"`) { |
| 1195 | t.Fatalf("rendered user config missing conversation_width:\n%s", rendered) |
| 1196 | } |
| 1197 | if project := RenderTOMLForScope(c, RenderScopeProject); strings.Contains(project, "conversation_width") { |
| 1198 | t.Fatalf("project config leaked user-only conversation_width:\n%s", project) |
| 1199 | } |
| 1200 | |
| 1201 | var got Config |
| 1202 | if _, err := toml.Decode(rendered, &got); err != nil { |
| 1203 | t.Fatalf("rendered TOML does not parse: %v\n---\n%s", err, rendered) |
| 1204 | } |
| 1205 | if got.DesktopConversationWidth() != "full" { |
| 1206 | t.Fatalf("conversation_width after round trip = %q, want full", got.DesktopConversationWidth()) |
| 1207 | } |
| 1208 | |
| 1209 | if err := c.SetDesktopConversationWidth("standard"); err != nil { |
| 1210 | t.Fatalf("reset conversation width: %v", err) |
| 1211 | } |
| 1212 | if rendered := RenderTOMLForScope(c, RenderScopeUser); strings.Contains(rendered, "conversation_width") { |
| 1213 | t.Fatalf("default conversation_width should be omitted:\n%s", rendered) |
| 1214 | } |
| 1215 | |
| 1216 | c.Desktop.ConversationWidth = " FULL " |
| 1217 | if rendered := RenderTOMLForScope(c, RenderScopeUser); !strings.Contains(rendered, `conversation_width = "full"`) { |
| 1218 | t.Fatalf("manually edited full width was not normalized:\n%s", rendered) |
| 1219 | } |
| 1220 | } |
| 1221 | |
| 1222 | func TestRenderTOMLDefaultStepsOmitted(t *testing.T) { |
| 1223 | isolateUserConfigHome(t) |
| 1224 | out := RenderTOML(Default()) |
| 1225 | agentLines := extractSectionLines(out, "[agent]") |
| 1226 | for _, line := range agentLines { |
| 1227 | if strings.Contains(line, "max_steps") || strings.Contains(line, "planner_max_steps") { |
| 1228 | t.Errorf("default step limits should be hidden from generated config, got: %s", line) |
| 1229 | } |
| 1230 | } |
| 1231 | } |
| 1232 | |
| 1233 | func TestRenderTOMLWindowsSandboxDefaultAndExplicitEnforceDisabled(t *testing.T) { |
| 1234 | isolateUserConfigHome(t) |
| 1235 | setRuntimeGOOS(t, "windows") |
| 1236 | |
| 1237 | defaultRendered := RenderTOMLForScope(Default(), RenderScopeUser) |
| 1238 | if !strings.Contains(defaultRendered, `bash = "off"`) { |
| 1239 | t.Fatalf("Windows default user config should render bash off:\n%s", defaultRendered) |
| 1240 | } |
| 1241 | |
| 1242 | cfg := Default() |
| 1243 | cfg.Sandbox.Bash = "enforce" |
| 1244 | delta := RenderTOMLProjectDelta(cfg) |
| 1245 | if strings.Contains(delta, `[sandbox]`) || strings.Contains(delta, `bash = `) { |
| 1246 | t.Fatalf("Windows explicit enforce should not render as an effective project delta:\n%s", delta) |
| 1247 | } |
| 1248 | } |
| 1249 | |
| 1250 | func extractSectionLines(toml, section string) []string { |
| 1251 | var lines []string |
| 1252 | inSection := false |
| 1253 | for line := range strings.SplitSeq(toml, "\n") { |
| 1254 | trimmed := strings.TrimSpace(line) |
| 1255 | if strings.HasPrefix(trimmed, section) { |
| 1256 | inSection = true |
| 1257 | continue |
| 1258 | } |
| 1259 | if inSection && strings.HasPrefix(trimmed, "[") && !strings.HasPrefix(trimmed, "[[") { |
| 1260 | break |
| 1261 | } |
| 1262 | if inSection { |
| 1263 | lines = append(lines, trimmed) |
| 1264 | } |
| 1265 | } |
| 1266 | return lines |
| 1267 | } |
| 1268 | |
| 1269 | func TestRenderTOMLOmitsDeprecatedAgentStepLimits(t *testing.T) { |
| 1270 | isolateUserConfigHome(t) |
| 1271 | c := Default() |
| 1272 | c.Agent.MaxSteps = 5 |
| 1273 | c.Agent.PlannerMaxSteps = 7 |
| 1274 | out := RenderTOML(c) |
| 1275 | for _, line := range extractSectionLines(out, "[agent]") { |
| 1276 | if strings.Contains(line, "max_steps") || strings.Contains(line, "planner_max_steps") { |
| 1277 | t.Fatalf("deprecated step limit should never be rendered, got: %s", line) |
| 1278 | } |
| 1279 | } |
| 1280 | } |
| 1281 | |
| 1282 | func TestLoadForEditIgnoresAndDropsDeprecatedAgentStepLimitsOnSave(t *testing.T) { |
| 1283 | isolateUserConfigHome(t) |
| 1284 | path := UserConfigPath() |
| 1285 | if err := os.MkdirAll(filepath.Dir(path), 0o755); err != nil { |
| 1286 | t.Fatal(err) |
| 1287 | } |
| 1288 | if err := os.WriteFile(path, []byte("[agent]\nplanner_max_steps = 9\nmax_steps = 100\ntemperature = 0.4\n"), 0o644); err != nil { |
| 1289 | t.Fatal(err) |
| 1290 | } |
| 1291 | |
| 1292 | cfg := LoadForEdit(path) |
| 1293 | if cfg.Agent.MaxSteps != 0 || cfg.Agent.PlannerMaxSteps != 0 { |
| 1294 | t.Fatalf("deprecated limits should normalize to zero, got max=%d planner=%d", cfg.Agent.MaxSteps, cfg.Agent.PlannerMaxSteps) |
| 1295 | } |
| 1296 | if cfg.Agent.Temperature != 0.4 { |
| 1297 | t.Fatalf("unrelated agent setting changed: temperature=%v", cfg.Agent.Temperature) |
| 1298 | } |
| 1299 | if err := cfg.SaveTo(path); err != nil { |
| 1300 | t.Fatal(err) |
| 1301 | } |
| 1302 | raw, err := os.ReadFile(path) |
| 1303 | if err != nil { |
| 1304 | t.Fatal(err) |
| 1305 | } |
| 1306 | if _, changed := stripLegacyAgentStepLimitLines(string(raw)); changed { |
| 1307 | t.Fatalf("saved config retained deprecated step limits:\n%s", raw) |
| 1308 | } |
| 1309 | } |
| 1310 | |
| 1311 | func TestIsolatedHomeDirEmptyByDefault(t *testing.T) { |
| 1312 | t.Setenv("REASONIX_HOME", "") |
| 1313 | if got := IsolatedHomeDir(); got != "" { |
| 1314 | t.Fatalf("IsolatedHomeDir() = %q, want empty", got) |
| 1315 | } |
| 1316 | } |
| 1317 | |
| 1318 | func TestIsolatedHomeDirReturnsCleanPath(t *testing.T) { |
| 1319 | raw := filepath.Join(t.TempDir(), "isolated-reasonix") |
| 1320 | t.Setenv("REASONIX_HOME", raw) |
| 1321 | got := IsolatedHomeDir() |
| 1322 | if filepath.Clean(got) != filepath.Clean(raw) { |
| 1323 | t.Fatalf("IsolatedHomeDir() = %q, want %q", got, raw) |
| 1324 | } |
| 1325 | } |
| 1326 | |
| 1327 | func TestLegacyOSSupportDirEmptyWhenIsolated(t *testing.T) { |
| 1328 | isolateUserConfigHome(t) |
| 1329 | t.Setenv("REASONIX_HOME", filepath.Join(t.TempDir(), "isolated-home")) |
| 1330 | if got := legacyOSSupportDir(); got != "" { |
| 1331 | t.Fatalf("legacyOSSupportDir() = %q, want empty when isolated", got) |
| 1332 | } |
| 1333 | } |
| 1334 | |
| 1335 | func TestLegacyXDGConfigPathsEmptyWhenIsolated(t *testing.T) { |
| 1336 | isolateUserConfigHome(t) |
| 1337 | t.Setenv("REASONIX_HOME", filepath.Join(t.TempDir(), "isolated-home")) |
| 1338 | if got := legacyXDGConfigPaths(); got != nil { |
| 1339 | t.Fatalf("legacyXDGConfigPaths() = %v, want nil when isolated", got) |
| 1340 | } |
| 1341 | } |
| 1342 | |
| 1343 | func TestCacheDirHonorsReasonixHome(t *testing.T) { |
| 1344 | home := t.TempDir() |
| 1345 | isolated := filepath.Join(home, "isolated-home") |
| 1346 | t.Setenv("HOME", home) |
| 1347 | t.Setenv("USERPROFILE", home) |
| 1348 | t.Setenv("REASONIX_HOME", isolated) |
| 1349 | |
| 1350 | got := CacheDir() |
| 1351 | want := filepath.Join(isolated, "cache") |
| 1352 | if filepath.Clean(got) != filepath.Clean(want) { |
| 1353 | t.Fatalf("CacheDir() = %q, want %q", got, want) |
| 1354 | } |
| 1355 | } |
| 1356 | |
| 1357 | func TestCacheDirHonorsReasonixCacheHomeOverReasonixHome(t *testing.T) { |
| 1358 | home := t.TempDir() |
| 1359 | cacheHome := filepath.Join(home, "custom-cache") |
| 1360 | t.Setenv("HOME", home) |
| 1361 | t.Setenv("USERPROFILE", home) |
| 1362 | t.Setenv("REASONIX_HOME", filepath.Join(home, "isolated-home")) |
| 1363 | t.Setenv("REASONIX_CACHE_HOME", cacheHome) |
| 1364 | |
| 1365 | got := CacheDir() |
| 1366 | want := cacheHome |
| 1367 | if filepath.Clean(got) != filepath.Clean(want) { |
| 1368 | t.Fatalf("CacheDir() = %q, want %q (REASONIX_CACHE_HOME must win)", got, want) |
| 1369 | } |
| 1370 | } |
| 1371 | |
| 1372 | func TestUserConfigLoadPathNoLegacyFallbackWhenIsolated(t *testing.T) { |
| 1373 | home := isolateUserConfigHome(t) |
| 1374 | isolated := filepath.Join(home, "isolated-home") |
| 1375 | t.Setenv("REASONIX_HOME", isolated) |
| 1376 | |
| 1377 | // Create a legacy config at the OS production path — it must not be loaded. |
| 1378 | productionHome := expectedDefaultReasonixHome(home) |
| 1379 | if err := os.MkdirAll(productionHome, 0o755); err != nil { |
| 1380 | t.Fatal(err) |
| 1381 | } |
| 1382 | if err := os.WriteFile(filepath.Join(productionHome, "config.toml"), []byte("default_model = \"production/model\"\n"), 0o600); err != nil { |
| 1383 | t.Fatal(err) |
| 1384 | } |
| 1385 | |
| 1386 | // The primary config under isolated home does not exist yet. |
| 1387 | got := userConfigLoadPath() |
| 1388 | want := filepath.Join(isolated, "config.toml") |
| 1389 | if filepath.Clean(got) != filepath.Clean(want) { |
| 1390 | t.Fatalf("userConfigLoadPath() = %q, want %q (must not fall back to production legacy config)", got, want) |
| 1391 | } |
| 1392 | } |
| 1393 | |
| 1394 | func TestCredentialSourceCandidatesSkipHomeEnvWhenIsolated(t *testing.T) { |
| 1395 | isolateUserConfigHome(t) |
| 1396 | t.Setenv("REASONIX_HOME", filepath.Join(t.TempDir(), "isolated-home")) |
| 1397 | |
| 1398 | // Write a key into the production home .env — it must not appear as a source. |
| 1399 | if home, err := os.UserHomeDir(); err == nil { |
| 1400 | if err := os.WriteFile(filepath.Join(home, ".env"), []byte("LEAKED_KEY=leaked-value\n"), 0o600); err != nil { |
| 1401 | t.Fatal(err) |
| 1402 | } |
| 1403 | } |
| 1404 | |
| 1405 | candidates := credentialSourceCandidates(".") |
| 1406 | for _, c := range candidates { |
| 1407 | if c.Kind == CredentialSourceHomeEnv { |
| 1408 | t.Fatalf("credentialSourceCandidates includes CredentialSourceHomeEnv when isolated: %v", c) |
| 1409 | } |
| 1410 | } |
| 1411 | } |
| 1412 | |
| 1413 | func TestMigrateLegacyIfNeededSkipsWhenIsolated(t *testing.T) { |
| 1414 | home := isolateUserConfigHome(t) |
| 1415 | isolated := filepath.Join(home, "isolated-home") |
| 1416 | t.Setenv("REASONIX_HOME", isolated) |
| 1417 | |
| 1418 | // Create a legacy config.json in production home — migration must skip it. |
| 1419 | legacyDir := filepath.Join(home, ".reasonix") |
| 1420 | if err := os.MkdirAll(legacyDir, 0o755); err != nil { |
| 1421 | t.Fatal(err) |
| 1422 | } |
| 1423 | if err := os.WriteFile(filepath.Join(legacyDir, "config.json"), []byte(`{"model":"production-model","apiKey":"sk-legacy"}`), 0o600); err != nil { |
| 1424 | t.Fatal(err) |
| 1425 | } |
| 1426 | |
| 1427 | res, err := MigrateLegacyIfNeeded() |
| 1428 | if err != nil { |
| 1429 | t.Fatalf("MigrateLegacyIfNeeded() error = %v", err) |
| 1430 | } |
| 1431 | if res != nil { |
| 1432 | t.Fatalf("MigrateLegacyIfNeeded() = %+v, want nil when isolated", res) |
| 1433 | } |
| 1434 | } |
| 1435 | |
| 1436 | // TestProjectConfigCannotOverrideSecrets pins [secrets] as a user-global |
| 1437 | // security control: a cloned repository's reasonix.toml must not be able to |
| 1438 | // opt the user into subprocess env stripping or sensitive-path hiding. |
| 1439 | func TestProjectConfigCannotOverrideSecrets(t *testing.T) { |
| 1440 | isolateUserConfigHome(t) |
| 1441 | t.Setenv("REASONIX_HOME", "") |
| 1442 | globalDir := filepath.Dir(UserConfigPath()) |
| 1443 | if err := os.MkdirAll(globalDir, 0o755); err != nil { |
| 1444 | t.Fatal(err) |
| 1445 | } |
| 1446 | globalTOML := "[secrets]\nfilter_subprocess_env = false\nprotect_sensitive_files = false\n" |
| 1447 | if err := os.WriteFile(filepath.Join(globalDir, "config.toml"), []byte(globalTOML), 0o644); err != nil { |
| 1448 | t.Fatal(err) |
| 1449 | } |
| 1450 | |
| 1451 | project := t.TempDir() |
| 1452 | projectTOML := "[secrets]\nfilter_subprocess_env = true\nprotect_sensitive_files = true\n" |
| 1453 | if err := os.WriteFile(filepath.Join(project, "reasonix.toml"), []byte(projectTOML), 0o644); err != nil { |
| 1454 | t.Fatal(err) |
| 1455 | } |
| 1456 | |
| 1457 | cfg, err := LoadForRoot(project) |
| 1458 | if err != nil { |
| 1459 | t.Fatalf("LoadForRoot() error = %v", err) |
| 1460 | } |
| 1461 | if cfg.Secrets.FilterSubprocessEnv { |
| 1462 | t.Error("project reasonix.toml enabled filter_subprocess_env; [secrets] must stay user-global") |
| 1463 | } |
| 1464 | if cfg.Secrets.ProtectSensitiveFiles { |
| 1465 | t.Error("project reasonix.toml enabled protect_sensitive_files; [secrets] must stay user-global") |
| 1466 | } |
| 1467 | } |
| 1468 | |
| 1469 | // TestRenderTOMLPersistsSecretsSection pins config-save round-tripping: the |
| 1470 | // renderer must emit [secrets] for the user scope or every WriteFile would |
| 1471 | // silently drop the user's security toggles. |
| 1472 | func TestRenderTOMLPersistsSecretsSection(t *testing.T) { |
| 1473 | cfg := Default() |
| 1474 | cfg.Secrets.FilterSubprocessEnv = true |
| 1475 | cfg.Secrets.ProtectSensitiveFiles = true |
| 1476 | |
| 1477 | out := RenderTOMLForScope(cfg, RenderScopeUser) |
| 1478 | for _, want := range []string{"[secrets]", "filter_subprocess_env = true", "protect_sensitive_files = true"} { |
| 1479 | if !strings.Contains(out, want) { |
| 1480 | t.Fatalf("user-scope render missing %q:\n%s", want, out) |
| 1481 | } |
| 1482 | } |
| 1483 | |
| 1484 | path := filepath.Join(t.TempDir(), "config.toml") |
| 1485 | if err := os.WriteFile(path, []byte(out), 0o644); err != nil { |
| 1486 | t.Fatal(err) |
| 1487 | } |
| 1488 | back := Default() |
| 1489 | if err := mergeFile(back, path); err != nil { |
| 1490 | t.Fatalf("round-trip decode: %v", err) |
| 1491 | } |
| 1492 | if !back.Secrets.FilterSubprocessEnv || !back.Secrets.ProtectSensitiveFiles { |
| 1493 | t.Fatalf("secrets toggles lost in render round-trip: %+v", back.Secrets) |
| 1494 | } |
| 1495 | |
| 1496 | // Project scope must not render the section — LoadForRoot ignores it there. |
| 1497 | if proj := RenderTOMLForScope(cfg, RenderScopeProject); strings.Contains(proj, "[secrets]") { |
| 1498 | t.Fatalf("project scope rendered [secrets]:\n%s", proj) |
| 1499 | } |
| 1500 | if strings.Contains(out, "redact_tool_output") { |
| 1501 | t.Fatalf("user-scope render still exposes removed live-redaction setting:\n%s", out) |
| 1502 | } |
| 1503 | } |
| 1504 |